feat: implement new address sorting algorithm #9847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
smira
commented
Nov 29, 2024
smira
force-pushed
the
feat/node-address-sort
branch
from
99fefc4 to
5d758af
Compare
7 tasks
smira
force-pushed
the
feat/node-address-sort
branch
2 times, most recently
from
b0e133f to
5cc4c60
Compare
smira
commented
Dec 4, 2024
| // ComparePrefixesLegacy is the old way to sort prefixes. | ||
| // | ||
| // It only compares addresses and does not take prefix length into account. | ||
| func ComparePrefixesLegacy(a, b netip.Prefix) int { |
There was a problem hiding this comment.
this function and the function below is the tl;dr of this change, everything else is just supporting stuff
smira
force-pushed
the
feat/node-address-sort
branch
from
5cc4c60 to
241c2d3
Compare
DmitriyMV
approved these changes
Dec 4, 2024
|
🆒 |
Fixes siderolabs#9725 See siderolabs#9749 Signed-off-by: Andrey Smirnov <[email protected]>
smira
force-pushed
the
feat/node-address-sort
branch
from
241c2d3 to
7d65071
Compare
|
/m |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9725
See #9749